馃彈Ignore react-dates related packages #21126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
suggested changes
Feb 27, 2019
| "moment-with-locales", | ||
| "react-addons-shallow-compare", | ||
| "react-externs", | ||
| "react-with-direction", |
There was a problem hiding this comment.
nit: Alphabetize this list for easy maintenance.
rsimha
approved these changes
Feb 27, 2019
|
Thanks for the review! |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Ignore react-dates related packages * Sort and cleanup * Update yarn.lock
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Ignore react-dates related packages * Sort and cleanup * Update yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21092
Should permanently resolve issues with renovate upgrading
react-dateswhen we don't actually want to upgrade it.