🏗 Copy form values from the browser to the HTML snapshot that gets uploaded to Percy for visual-diff tests #21213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @andrewwatterson bug fix for #20630 |
rsimha
approved these changes
Mar 1, 2019
|
Bammo! Thanks. :) |
|
New visual tests approved. Nice work! |
added 4 commits
March 4, 2019 13:22
…aded to Percy for visual-diff tests
danielrozenberg
force-pushed
the
visual-diff-freeze-forms
branch
from
9707e31
to
27577f2
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…loaded to Percy for visual-diff tests (ampproject#21213) * Copy form values from the browser to the HTML snapshot that gets uploaded to Percy for visual-diff tests * Error handling for request(...webpage.interactive_tests) file import failure * Add example amp-form demo that uses new form-freezing feature * Update the comment on `freeze-form-values.js`
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
…loaded to Percy for visual-diff tests (ampproject#21213) * Copy form values from the browser to the HTML snapshot that gets uploaded to Percy for visual-diff tests * Error handling for request(...webpage.interactive_tests) file import failure * Add example amp-form demo that uses new form-freezing feature * Update the comment on `freeze-form-values.js`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
requireing an interactive test file crashes the visual diff tests runner<amp-form>visual diff tests to show that this really fixes Visual testing framework: hard code input values into DOM snapshot to send to Percy #20630