Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix layers dirtying after resize #21215

Merged
merged 1 commit into from Mar 1, 2019

Conversation

jridgewell
Copy link
Contributor

I pushed the Element into dirtySet, not the ChangeHeightRequest.

I pushed the Element into `dirtySet`, not the `ChangeHeightRequest`.
@jridgewell
Copy link
Contributor Author

/to @choumx

Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type check doesn't catch this?

@jridgewell
Copy link
Contributor Author

I don't know what happened... 🤷‍♂️

@jridgewell jridgewell merged commit 7bcc25d into ampproject:master Mar 1, 2019
@jridgewell jridgewell deleted the fix-layers-1 branch March 1, 2019 23:44
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
I pushed the Element into `dirtySet`, not the `ChangeHeightRequest`.
bramanudom pushed a commit to bramanudom/amphtml that referenced this pull request Mar 22, 2019
I pushed the Element into `dirtySet`, not the `ChangeHeightRequest`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants