Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰Fix call on undefined property forEach #21232

Merged
merged 1 commit into from Mar 4, 2019
Merged

馃悰Fix call on undefined property forEach #21232

merged 1 commit into from Mar 4, 2019

Conversation

cvializ
Copy link
Contributor

@cvializ cvializ commented Mar 4, 2019

Fixes #21098

dreamofabear
dreamofabear approved these changes Mar 4, 2019
View reviewed changes
Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@cvializ
Copy link
Contributor Author

cvializ commented Mar 4, 2019

np, I LGTMed it so double-oops haha

@cvializ cvializ merged commit 7a23702 into ampproject:master Mar 4, 2019
@jridgewell jridgewell mentioned this pull request Mar 4, 2019
Closed
@cvializ cvializ mentioned this pull request Mar 5, 2019
Closed
@aghassemi
Copy link
Contributor

@cvializ @choumx I suggest patching current Canary that is about to go release with this, given it is both Edge and IE11 and form submission is big for ALP.

@cvializ cvializ mentioned this pull request Mar 5, 2019
Closed
@cramforce
Copy link
Member

Please file an issue to disallow the bad pattern via https://github.com/ampproject/amphtml/blob/master/build-system/conformance-config.textproto

@jridgewell
Copy link
Contributor

Please file an issue to disallow the bad pattern

Already done in #21234, although it's impossible due to our crappy type information.

erwinmombay pushed a commit that referenced this pull request Mar 5, 2019
@cvializ @erwinmombay
Fix call on undefined property forEach (#21232)
8680ca6
@zhouyx zhouyx mentioned this pull request Mar 7, 2019
Closed
7 tasks
jridgewell pushed a commit that referenced this pull request Mar 14, 2019
@cvializ @jridgewell
Fix call on undefined property forEach (#21232)
ad16950
@aghassemi aghassemi mentioned this pull request Mar 15, 2019
Closed
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@cvializ
Fix call on undefined property forEach (ampproject#21232)
1b9f4ce
bramanudom pushed a commit to bramanudom/amphtml that referenced this pull request Mar 22, 2019
@cvializ @bramanudom
Fix call on undefined property forEach (ampproject#21232)
88ba666
@cvializ cvializ deleted the fix/form-ie branch April 2, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

@torch2424 torch2424 Awaiting requested review from torch2424

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cvializ @aghassemi @cramforce @jridgewell @dreamofabear @googlebot