Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈馃悰 Fix two bugs in PR check #21272

Merged
merged 1 commit into from Mar 5, 2019
Merged

馃彈馃悰 Fix two bugs in PR check #21272

merged 1 commit into from Mar 5, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Mar 5, 2019

  1. There's a missing arg to downloadDistOutput() in dist-tests.js
  2. We're not printing the contents of the dist/v0/ directory after downloading the output

https://travis-ci.org/ampproject/amphtml/jobs/501748811#L1222

@rsimha rsimha self-assigned this Mar 5, 2019
@rsimha rsimha requested a review from estherkim March 5, 2019 17:19
@rsimha
Copy link
Contributor Author

rsimha commented Mar 5, 2019

/to @estherkim

Copy link
Collaborator

@estherkim estherkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rsimha rsimha merged commit 5503bc9 into ampproject:master Mar 5, 2019
@rsimha rsimha deleted the 2019-03-05-Utils branch March 5, 2019 18:19
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
bramanudom pushed a commit to bramanudom/amphtml that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants