New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 amp-geo: Target AMP body with class changes (#20946) #21282
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLA signed |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Use getAmpDoc method to obtain document and body, fixing compatibility with PWAs, where the body is not simply window.document.body. Fixes #20946
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @choumx Does this fit with out plans for AmpDoc? |
Please do not merge. Issue found: |
@matthewlane Thank you for contributing and submitting the fix! Let's aiming at get #21293 in before the canary cut as well. Thank you |
* amp-geo: Fix inconsistent geoState parent PR #21282 introduced a new issue where the #ampGeo <amp-state> would be appended to the ampdoc body but searched for in the win.doc body. Look for #ampGeo in ampdoc. * amp-geo: Apply clearPreRender to AMP body PR #21282 changed the location of amp-geo related classes to the AMP document body. Propagate the change to the clearPreRender_method as well. * amp-geo: Consistently use ampdoc in addToBody_ It is not necessary to retain both doc and ampdoc in the addToBody_ method. Update to use only ampdoc.
Looks fine to me. |
…project#21282) * 🐛 amp-geo: Target AMP body with class changes (ampproject#20946) Use getAmpDoc method to obtain document and body, fixing compatibility with PWAs, where the body is not simply window.document.body. Fixes ampproject#20946 * typo in comment
* amp-geo: Fix inconsistent geoState parent PR ampproject#21282 introduced a new issue where the #ampGeo <amp-state> would be appended to the ampdoc body but searched for in the win.doc body. Look for #ampGeo in ampdoc. * amp-geo: Apply clearPreRender to AMP body PR ampproject#21282 changed the location of amp-geo related classes to the AMP document body. Propagate the change to the clearPreRender_method as well. * amp-geo: Consistently use ampdoc in addToBody_ It is not necessary to retain both doc and ampdoc in the addToBody_ method. Update to use only ampdoc.
…project#21282) * 🐛 amp-geo: Target AMP body with class changes (ampproject#20946) Use getAmpDoc method to obtain document and body, fixing compatibility with PWAs, where the body is not simply window.document.body. Fixes ampproject#20946 * typo in comment
* amp-geo: Fix inconsistent geoState parent PR ampproject#21282 introduced a new issue where the #ampGeo <amp-state> would be appended to the ampdoc body but searched for in the win.doc body. Look for #ampGeo in ampdoc. * amp-geo: Apply clearPreRender to AMP body PR ampproject#21282 changed the location of amp-geo related classes to the AMP document body. Propagate the change to the clearPreRender_method as well. * amp-geo: Consistently use ampdoc in addToBody_ It is not necessary to retain both doc and ampdoc in the addToBody_ method. Update to use only ampdoc.
Use
getAmpDoc
method to obtaindocument
andbody
, fixing compatibilitywith PWAs, where the body is not simply
window.document.body
.Fixes #20946