Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃枍 Add preliminary styles for amp-autocomplete #21479

Merged
merged 8 commits into from Apr 5, 2019

Conversation

andrewwatterson
Copy link
Contributor

Builds on @caroqliu's work on amp-autocomplete - this adds some styling to the autocomplete input and results list.

Very much a work in progress.

@andrewwatterson
Copy link
Contributor Author

@cvializ @caroqliu - This has been as "ready" as any other pre-release autocomplete code for awhile, though it may be incomplete.

The only thing we might want to change before merge is that I had to manually reset a bunch of the i-amphtml-fill-content styles that were applied to i-amphtml-autocomplete-results. Did we ever investigate whether we can avoid adding the fill-content styles in the first place?

@cvializ
Copy link
Contributor

cvializ commented Apr 2, 2019

Yes, @caroqliu investigated and was able to remove the applyFillContent call, so those styles shouldn't be needed. You can merge this branch with master and see those changes in your PR so you can remove the style overrides.

@andrewwatterson
Copy link
Contributor Author

Arrite @cvializ I took those styles out. Assuming it passes checks, should be good to merge.

Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cvializ cvializ merged commit f52c37a into ampproject:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants