New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
鉁╝mp-consent: consent-ui Allow Passing Initial styles on ready #21522
鉁╝mp-consent: consent-ui Allow Passing Initial styles on ready #21522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two minor comments.
); | ||
} | ||
} else { | ||
dev().error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user().error instead.
if (dataHeight >= 10 && dataHeight <= 60) { | ||
this.initialHeight_ = `${dataHeight}vh`; | ||
} else { | ||
dev().error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user().error
closes #21324
This allows for setting an initial height between
10vh
and60vh
on iframe ready. As well as optionally removing the border radius and box shadow on the consent iframe container 馃槃Example