✅ Add validation rules for amp-autocomplete. #21526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@honeybadgerdontcare (or @Gregable ): I discussed this with @caroqliu and we were both puzzling over how to accomplish the above validation logic. Any advice? |
|
@cvializ yes, this is something I'm looking into |
|
Thanks! |
extensions/amp-autocomplete/validator-amp-autocomplete.protoascii
Outdated
Show resolved
Hide resolved
caroqliu
force-pushed
the
autocomplete-validations
branch
from
1591ae0
to
604556f
Compare
|
Made the changes we discussed offline yesterday, ptal @cvializ |
honeybadgerdontcare
approved these changes
Apr 25, 2019
caroqliu
changed the title
Merged
honeybadgerdontcare
added a commit
that referenced
this pull request
Apr 26, 2019
caroqliu
added a commit
to caroqliu/amphtml
that referenced
this pull request
Apr 29, 2019
* Create validation files * Add validation test HTML file * Add validator rules and update out * Update validator rules * Attempt validate template usage * Undo nested input * Modify validation rules * Change "value" to "data-value" * Remove unwanted valid cases from validator tests * Update data-value in test * minor nits
caroqliu
pushed a commit
to caroqliu/amphtml
that referenced
this pull request
Apr 29, 2019
* cl/243147325 Revision bump for ampproject#21770 * cl/244691564 Revision bump for ampproject#21552 * cl/245095560 Allow i-amphtml-sizer as child of amp-image-slider. * cl/245331243 Allow i-amphtml-sizer as child of amp-video-iframe. * cl/245480181 Revision bump for ampproject#21526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.