Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰Use variable macros for 'enabled' string expansion #21537

Merged
merged 1 commit into from Mar 27, 2019

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Mar 22, 2019

No description provided.

@zhouyx zhouyx requested a review from calebcordry March 22, 2019 14:49
@jeffjose jeffjose added this to Needs triage in Analytics via automation Mar 22, 2019
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to add this in a couple more places in PR #21409. I will also try to do an audit and see if we are missing it anywhere else.

@calebcordry
Copy link
Member

Good catch. Thanks for the fix!

@zhouyx zhouyx merged commit efba3b2 into ampproject:master Mar 27, 2019
@zhouyx zhouyx deleted the fix branch March 27, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Analytics
  
Needs triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants