Clean up test-amp-state.js #21540
Merged
Clean up test-amp-state.js #21540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
commented
Mar 22, 2019
•
dreamofabear
commented
- Avoid stubbing private functions as much as possible.
- Use await/async for more readable control flow.
dreamofabear
force-pushed
the
amp-state-tests
branch
from
641cbe0
to
d1189dc
Compare
dreamofabear
force-pushed
the
amp-state-tests
branch
from
d1189dc
to
b92048c
Compare
|
Is this PR still active? |
|
Yes! Will get it merged soon. |
|
/to @jridgewell |
jridgewell
approved these changes
Aug 6, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Clean up test-amp-state.js. * Apply prettier. * Use async/await. * Fix lint. * Add more setState args expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.