Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Delegate trust check to action handler (#21553)" #21563

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Revert "Delegate trust check to action handler (#21553)" #21563

merged 1 commit into from
Mar 26, 2019

Conversation

erwinmombay
Copy link
Member

No description provided.

rsimha
rsimha approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock master

@erwinmombay
Copy link
Member Author

weird getting TypeError: invocation.satisfiesTrust is not a function on a bunch of unit tests

@erwinmombay
Copy link
Member Author

@choumx do you have an idea why this is happening?

@erwinmombay erwinmombay changed the title return null and not undefined if does not satisfy trust action Revert "Delegate trust check to action handler (#21553)" Mar 25, 2019
@cvializ cvializ mentioned this pull request Mar 26, 2019
Closed
@erwinmombay erwinmombay reopened this Mar 26, 2019
@erwinmombay
Copy link
Member Author

force merging to get master green

@erwinmombay erwinmombay merged commit d96498b into ampproject:master Mar 26, 2019
dreamofabear pushed a commit to dreamofabear/amphtml that referenced this pull request Apr 1, 2019
Revert "Revert "Delegate trust check to action handler (ampproject#21553
881cf5f 
)" (ampproject#21563)"

This reverts commit d96498b.
dreamofabear pushed a commit that referenced this pull request Apr 3, 2019
Roll forward "Delegate trust check... (#21553)" (#21653)
5763c3b 
* Revert "Revert "Delegate trust check to action handler (#21553)" (#21563)"

This reverts commit d96498b.

* Fix type check.

* Fix test-amp-access.js.

* Fix test-amp-form.js.

* Test trust check in amp-access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

@dreamofabear dreamofabear Awaiting requested review from dreamofabear

Assignees
No one assigned
Labels
cla: yes P1: High Priority PR use: In Beta / Experimental Type: Bug WG: access-subscriptions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erwinmombay @rsimha @googlebot @ampprojectbot