Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃枍 amp-social-share: update brand colors for facebook and pinterest #21575

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Jessman5
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@Jessman5
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@cathyxz
Copy link
Contributor

cathyxz commented Mar 26, 2019

Thanks a lot for this! I think you've branched off a broken build--sorry. Would you mind merging or rebasing latest master?

@Jessman5
Copy link
Contributor Author

damn, sure. Thank you

used in amp-social-share module
@Jessman5
Copy link
Contributor Author

@cathyxz my branch is now up to date.

Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aghassemi aghassemi merged commit 9770d36 into ampproject:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants