Fix amp-audio on the first page of a story. #21611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
reviewed
Mar 28, 2019
newmuis
approved these changes
Mar 28, 2019
| mediaEl = /** @type {!./media-pool.DomElementDef} */ (mediaEl); | ||
| const promises = [mediaPool.unmute(mediaEl)]; | ||
|
|
||
| // Audio element on the first page of a story would not be playing since |
There was a problem hiding this comment.
nit: it's not necessarily just the first page, it could potentially be any page where the browser has rejected playback for whatever reason. Not sure if it's worth trying to message that here, for future readers
gmajoulet
force-pushed
the
amp_audio_first_page
branch
from
421573d
to
6616fde
Compare
|
PTAL |
gmajoulet
force-pushed
the
amp_audio_first_page
branch
from
fa76918
to
437b8e9
Compare
Enriqe
approved these changes
Mar 28, 2019
newmuis
reviewed
Mar 28, 2019
|
PTAL |
newmuis
approved these changes
Mar 29, 2019
gmajoulet
force-pushed
the
amp_audio_first_page
branch
from
f8f4c1f
to
df039ce
Compare
gmajoulet
commented
Mar 29, 2019
gmajoulet
force-pushed
the
amp_audio_first_page
branch
from
df039ce
to
8d12593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an
amp-audioelement on the first page of a story has two issues:Fixes #21604