🚀 amp-subscriptions prerender

extensions/amp-subscriptions-google/0.1/amp-subscriptions-google.js

@@ -215,6 +215,18 @@ export class GoogleSubscriptionsPlatform {
         'success');
   }
 
+  /** @override */
+  isPrerenderSafe() {
+    /**
+     * If it's a google viewer then calling google for an
+     * entitlement at prerender time does not leak any private
+     * information.  If it's not a google viewer then we wait
+     * for the page to be visible to avoid leaking that the
+     * page was prerendered
+     */
+    return this.isGoogleViewer_;
+  }
+
   /** @override */
   getEntitlements() {
     return this.runtime_.getEntitlements().then(swgEntitlements => {

extensions/amp-subscriptions-google/0.1/test/test-amp-subscriptions-google.js

@@ -258,6 +258,11 @@ describes.realWin('amp-subscriptions-google', {amp: true}, env => {
     expect(methods.linkAccount).to.not.be.called;
   });
 
+  it('should not allow prerender for non-google viewer', () => {
+    platform.isGoogleViewer_ = false;
+    expect(platform.isPrerenderSafe()).to.be.false;
+  });
+
   it('should reauthorize on complete linking', () => {
     analyticsMock.expects('actionEvent')
         .withExactArgs(PLATFORM_ID, 'link', 'success')
@@ -389,6 +394,12 @@ describes.realWin('amp-subscriptions-google', {amp: true}, env => {
     });
   });
 
+  it('should allow prerender if in a google viewer', () => {
+    viewer.params_['viewerUrl'] = 'https://www.google.com/other';
+    platform = new GoogleSubscriptionsPlatform(ampdoc, {}, serviceAdapter);
+    expect(platform.isPrerenderSafe()).to.be.true;
+  });
+
   it('should attach button given to decorateUI', () => {
     const elem = env.win.document.createElement('div');
     const decorateStub = sandbox.stub(platform.runtime_.buttonApi_,

extensions/amp-subscriptions/0.1/amp-subscriptions.js

@@ -242,7 +242,11 @@ export class SubscriptionService {
     if (getMode().development || getMode().localDev) {
       timeout = SERVICE_TIMEOUT * 2;
     }
-    return this.viewer_.whenFirstVisible().then(() => {
+    // Prerender safe platforms don't have to wait for the
+    // page to become visible, all others wait for whenFirstVisible()
+    const visiblePromise = subscriptionPlatform.isPrerenderSafe() ?
+      Promise.resolve() : this.viewer_.whenFirstVisible();
+    return visiblePromise.then(() => {
       return this.timer_.timeoutPromise(
           timeout,
           subscriptionPlatform.getEntitlements()

extensions/amp-subscriptions/0.1/local-subscription-platform.js

@@ -178,6 +178,12 @@ export class LocalSubscriptionPlatform {
     });
   }
 
+  /** @override */
+  isPrerenderSafe() {
+    // Local platform can never be allowed to prerender in a viewer
+    return false;
+  }
+
   /** @override */
   getEntitlements() {
     return this.urlBuilder_.buildUrl(this.authorizationUrl_,

extensions/amp-subscriptions/0.1/subscription-platform.js

@@ -51,6 +51,13 @@ export class SubscriptionPlatform {
    */
   reset() {}
 
+  /**
+   * True if this platform can fetch entitlement safely in pre-render
+   * without leaking information to the publisher or a 3rd party
+   * @return {boolean}
+   */
+  isPrerenderSafe() {}
+
   /**
    * Returns if pingback is enabled for this platform.
    * @return {boolean}

extensions/amp-subscriptions/0.1/test/test-local-subscriptions.js

@@ -85,6 +85,10 @@ describes.fakeWin('LocalSubscriptionsPlatform', {amp: true}, env => {
     expect(localSubscriptionPlatform.getBaseScore()).to.be.equal(99);
   });
 
+  it('Should not allow prerender', () => {
+    expect(localSubscriptionPlatform.isPrerenderSafe()).to.be.false;
+  });
+
   it('should fetch the entitlements on getEntitlements', () => {
     const fetchStub = sandbox.stub(localSubscriptionPlatform.xhr_, 'fetchJson')
         .callsFake(() => Promise.resolve({json: () => Promise.resolve(json)}));

extensions/amp-subscriptions/0.1/test/test-viewer-platform.js

@@ -89,6 +89,10 @@ describes.fakeWin('ViewerSubscriptionPlatform', {amp: true}, env => {
     });
   });
 
+  it('Should  allow prerender', () => {
+    expect(viewerPlatform.isPrerenderSafe()).to.be.true;
+  });
+
   describe('verifyAuthToken_', () => {
     const entitlement = Entitlement.parseFromJson(entitlementData);
     entitlement.service = 'local';

extensions/amp-subscriptions/0.1/viewer-subscription-platform.js

@@ -64,6 +64,11 @@ export class ViewerSubscriptionPlatform {
     this.origin_ = origin;
   }
 
+  /** @override */
+  isPrerenderSafe() {
+    return true;
+  }
+
   /** @override */
   getEntitlements() {
     devAssert(this.currentProductId_, 'Current product is not set');