Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

鉁╝mp-recaptcha-input: Removed experiment from amp-recaptcha-input #21664

Merged

Conversation

torch2424
Copy link
Contributor

closes #2273

This removes the experiment for amp-recaptcha-input. Thus launching this feature, and making this available to the public! 馃槃

This should be approved before April 8th, 2019, and merged on April 8th, 2019. In order to line up with a certain date 馃憖

Also, this should have a paired documentation update to inform users the feature is no longer experimental 馃槃 After this goes live in PROD (to avoid confusion).

Example

Screen Shot 2019-04-01 at 3 25 09 PM

@torch2424
Copy link
Contributor Author

torch2424 commented Apr 2, 2019

Per @aghassemi suggestion, this should actually be merged for today's release, in order to ensure that this is in prod for the certain date. In case of a revert 馃槃

@torch2424
Copy link
Contributor Author

Thank you @aghassemi ! 馃槃 Merging...

@torch2424 torch2424 merged commit 4a26197 into ampproject:master Apr 2, 2019
@torch2424 torch2424 deleted the amp-recaptcha-input-remove-experiment branch April 2, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reCAPTCHA component
3 participants