馃悰 Layers: Bust Resource's measurements when dirtying #21748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Layers experiment was enabled, dirtying the element would invalidate Layer's cached measurements. But I forgot to invalidate Resource's measurement state, which controls signals to the AMP elements (like, `onLayoutMeasure` and `onMeasureChanged`). This has a particularly bad affect on A4A ads, since they initiate ads requests during `onLayoutMeasure`!
jeffkaufman
approved these changes
Apr 8, 2019
| r.requestMeasure(); | ||
| } | ||
| const ampElements = element.getElementsByClassName('i-amphtml-element'); | ||
| for (let i = 0; i < ampElements.length; i++) { |
There was a problem hiding this comment.
why not:
for (const ampElement of element.getElementsByClassName('i-amphtml-element') {
...
There was a problem hiding this comment.
We can't use for-of loops because it requires a Symbol.iterator (and Symbol) polyfill.
dreamofabear
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Layers experiment was enabled, dirtying the element would invalidate Layer's cached measurements. But I forgot to invalidate Resource's measurement state, which controls signals to the AMP elements (like,
onLayoutMeasureandonMeasureChanged).This has a particularly bad affect on A4A ads, since they initiate ads requests during
onLayoutMeasure!