Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Skip amp-list e2e tests for now #21798

Merged
merged 2 commits into from Apr 10, 2019
Merged

✅ Skip amp-list e2e tests for now #21798

merged 2 commits into from Apr 10, 2019

Conversation

estherkim
Copy link
Collaborator

@estherkim estherkim requested a review from cvializ April 10, 2019 16:12
@estherkim estherkim requested a review from rsimha April 10, 2019 16:13
rsimha
rsimha approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding comments above failing tests with an assignee and a tracking issue ID.

extensions/amp-list/0.1/test-e2e/test-load-more-auto.js Show resolved Hide resolved
@estherkim estherkim merged commit 916afe3 into ampproject:master Apr 10, 2019
@estherkim estherkim deleted the skip-amp-list branch April 10, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathyxz cathyxz cathyxz left review comments

@rsimha rsimha rsimha approved these changes

@cvializ cvializ Awaiting requested review from cvializ

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@estherkim @cathyxz @rsimha @googlebot