馃悰amp-autocomplete: Fix submit-on-enter bug #21800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caroqliu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a submit-on-enter bug wherein
submit-on-enter="false"fails to prevent form submission whenEnteris pressed while suggestions are displaying. The updated behavior is as follows:submit-on-enter="true"does not disrupt any consequences of pressingEnterin the containing input field of anamp-autocomplete.submit-on-enter="false"will prevent default behavior only if suggestions are displayed. This is because the default consequences of pressingEntershould only be disrupted when there is a new interaction pattern for it, such as selecting an item from a list of suggestions, which is not possible when no suggestions are displayed.activeElement_andactiveIndex_