Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicity --unit to automated tests that run on --local-changes #21851

Merged
merged 2 commits into from Apr 16, 2019

Conversation

danielrozenberg
Copy link
Member

Fixed that issue noticed by Raghu in #21407 (review)

Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after one change.

build-system/default-pre-push Outdated Show resolved Hide resolved
@cathyxz
Copy link
Contributor

cathyxz commented Apr 16, 2019

What happens if you don't add --unit to --local-changes? Is the heuristic smart enough to run the correct set of runtime tests?

@danielrozenberg
Copy link
Member Author

@cathyxz yes, it'll still run the unit tests without it. This is for the test status bot (followup for #21407) to report the correct type of testing being done when running --local-changes

@cathyxz
Copy link
Contributor

cathyxz commented Apr 16, 2019

Super cool. Thanks!

@danielrozenberg danielrozenberg merged commit 16d0520 into ampproject:master Apr 16, 2019
@danielrozenberg danielrozenberg deleted the explicit-unit branch April 16, 2019 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants