Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update amp-list tests #22030

Merged
merged 5 commits into from Apr 29, 2019
Merged

Update amp-list tests #22030

merged 5 commits into from Apr 29, 2019

Conversation

cathyxz
Copy link
Contributor

@cathyxz cathyxz commented Apr 26, 2019 •
edited

Remove flaky integration tests in favor of unit tests. Write additional tests for amp-list-load-more.

Closes #21993

@cathyxz cathyxz requested a review from cvializ April 26, 2019 21:44
cvializ
cvializ approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cathyxz cathyxz mentioned this pull request Apr 29, 2019
Closed
@cathyxz cathyxz merged commit 68c6465 into ampproject:master Apr 29, 2019
@rsimha
Copy link
Contributor

rsimha commented Apr 29, 2019

👍 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvializ cvializ cvializ approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various amp-list tests are timing out on Travis (local Chrome)
5 participants
@cathyxz @rsimha @cvializ @googlebot @ampprojectbot