Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the URL generated for the predefined requests of all vendor configs. #2211

Merged
merged 1 commit into from Feb 23, 2016

Conversation

cramforce
Copy link
Member

This will make:

  • inadvertent changes in the future harder.
  • provides some easy to see reference how the generated URLs will look like.

@cramforce
Copy link
Member Author

CC @rudygalfi Vendors will have to update this in the future.

@cramforce cramforce force-pushed the analytics-sanity branch 4 times, most recently from 4e4f73a to a6c1d30 Compare February 23, 2016 02:20
…igs.

This will make:

- inadvertend changes in the future harder.
- provides some easy to see reference how the generated URLs will look like.
@cramforce
Copy link
Member Author

Merging, because I'm don't like needing to update the golden values myself all the time.

cramforce added a commit that referenced this pull request Feb 23, 2016
Test the URL generated for the predefined requests of all vendor configs.
@cramforce cramforce merged commit c7e4fbd into ampproject:master Feb 23, 2016
@cramforce cramforce deleted the analytics-sanity branch February 23, 2016 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants