🏗Extract and indirect log message string #22146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
commented
May 6, 2019
alanorozco
commented
May 6, 2019
# Conflicts: # build-system/build.conf.js
jridgewell
approved these changes
May 23, 2019
alanorozco
force-pushed
the
extract-logs
branch
2 times, most recently
from
01998c9
to
7759d83
Compare
Codecov Report
@@ Coverage Diff @@
## master #22146 +/- ##
===========================================
- Coverage 85.63% 41.02% -44.62%
===========================================
Files 1556 237 -1319
Lines 146115 20491 -125624
===========================================
- Hits 125130 8407 -116723
+ Misses 20985 12084 -8901
Continue to review full report at Codecov.
|
erwinmombay
reviewed
May 28, 2019
erwinmombay
approved these changes
May 28, 2019
This was referenced May 30, 2019
# Conflicts: # build-system/build.conf.js # build-system/compile/single-pass.js
kristoferbaxter
approved these changes
Jul 22, 2019
jridgewell
approved these changes
Jul 22, 2019
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
Reduces binary size by creating a table of log messages to be served from a URL (~2.8% bundle size reduction). This change does NOT turn on message replacement, only extraction. Next release is planned to turn replacements on.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
Reduces binary size by creating a table of log messages to be served from a URL (~2.8% bundle size reduction). This change does NOT turn on message replacement, only extraction. Next release is planned to turn replacements on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress.
Picks up from #19870
Reduces binary size by creating a table of log messages to be served from a URL.
v0 size
singlepass
with
compressasbrotliorgzip:67046814636527779178~2.8% reduction.
multipassRemoved from PR.
Issues with strings not indirected
ActionService.error_is used with variable messages (6). We could add a helper method toLogto specify strings that should be indirected.