馃悰amp-recaptcha-input: Added support for error returning null #22456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
reviewed
Jun 27, 2019
| @@ -165,12 +165,18 @@ function actionTypeHandler(win, grecaptcha, data) { | |||
| ); | |||
| }, | |||
| function(err) { | |||
| user().error(TAG, '%s', err.message); | |||
| let message = | |||
There was a problem hiding this comment.
Ha! Interesting, Didn't know the error can be null. In such case is it still a valid error that we want to report. Or can we ignore them?
There was a problem hiding this comment.
So the output of err is undefined, so I do think it is worth reporting. Because usually I have seen this in bugs as a configuration error with the user's recaptcha dashboard, and not an error on us 馃槃
zhouyx
approved these changes
Jun 27, 2019
|
Thank you very much for the review! @zhouyx 馃槃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #22279
This fixes the error handler throwing an error when the err that is returned by the reCAPTCHA script is null.
EDIT: Confirmed with team directly, error can be null
Example
If I put the test code:
It shows the error can be null:
Just proof the script is loaded correctly: