📖amp-consent: Add Didomi CMP documentation + example #22518
Conversation
* Fallback * Add fallback elements to example * Lint * Reset fallbackDisplayed_ when clearing items * Add unit tests for fallback and check types * Lint * Lint * Update tests * New approach to fallback * Remove fallback class * Refactor tests * Update test to reject promise instead of throw erro * Update types * Undo auto HTML lint * Carlos comments * Update unit test
* applyFillContent on amp-ad-custom * Add examples.
|
Per your comment in #21752 Feel free to @ mention me when things are finished up on your side, so I can take a look, review, and get this merged 😄 |
…roject#21466) * Display partial user input in bold for each filtered item * Support substring highlighting for rich content * /*OK*/ innerHTML; calls occur in mutate context * Set default value for optional substring param * Expose styling class * Lint * Reflect change in tests * Lint * Sanitize for plain text case * Remove rich case * Replace regex with node building implementation * Remove sanitizeHtml * Add highlight-user-entry attribute * Add tests for both partial highlighting and not * Lint * Undo automatic HTML linting * Update .out file to undo auto lint * Add highlight-user-entry attribute to md
- Implement a single version of truncate, where the optional overflow element is the last child of the component. - Use overflow for truncation. Doing various optimizations (like using Range) requires more work and has a lot of cases to consider. The potential benefit is in the range of 5x-10x performance. - Implement both a Shadow DOM and non-Shadow DOM version of the component, with the Shadow DOM behind a separate flag. * The tests run against both versions. - Add `slot` to validator global attributes.
* move markPageAsLoaded_ to buildCallback * move mediaLayoutPromise declaration until it is needed * change to a deferred pattern * replace whenLoaded with CommonSignals.LOAD_END * actually call media fn * fix test in amp story to wait for page signals to end * mark page as loaded right after media is loaded * remove markpageasloaded * Revert "remove markpageasloaded" This reverts commit 7cf6f24.
…#22469) * Support multi entitlement pingback * add pingbackReturnsAllEntitlements support
* Change form attributes in example * Allow relative src URLs
* Bug fix: use timer to track page engagement * Adds support for tracking custom events
…ons (ampproject#22349) * Started the allow list * Implemented the old functionality in new allow list format * Fixed up lintintg * Fixed a bug so far * Finished the allowed list * Added / Fixed all tests for the attribute list * Fixed up prettier linting * Removed the test, can be added back once source is reviewed * Made Requested offline changes * Made requested changes * Added/fixed tests for the current changes * Fixed precommit checks * Made comment changes * Made PR Comments
* Fix invisible sidebar in email/actions. * Fix lint.
* cl/249302791 Remove non-AMP formats for carousel reference points. * cl/249465797 Revision bump for ampproject#22417 * cl/249525181 Revision bump for ampproject#22182 * cl/249558901 Revision bump for ampproject#22447 * cl/250316079 Revision bump for ampproject#22470 * cl/250386704 Revision bump for ampproject#22488
* Export `isDisabled` helper The `isDisabled` helper will be used to determine if an element should skip the dirtiness check. * Split test cases to only test for one behavior * s/fieldset/elementAncestralFieldset
* Remove unnecessary bits * Change md phrasing
* Extract `isFieldDefault` helper Extract an common helper that can be used for form field dirtiness check. * Split text cases to only test for one behavior * explicitly set state without relying on beforeEach * move isFieldDefault to src/form.js * Add comments on why elements are inserted as HTML
…oject#22645) * Remove AMP-Access-Control-Allow-Source-Origin from test server * fix rebase
* Install Timer service directly instead of adopting * fixes * fix tests * lints * revert timer lookup * review fixes
* bypass xhr interceptor for amp-worker invocation * fix type typo * choumx comments * add test * fix check-types * choumx comments
|
Thank you for your integration. LGTM! 🎉 |
|
I restarted the travis build. See different error @estherkim This looks similar to the error I saw from #22696. Do you think rebase will solve the issue. Thank you! |
* Use css.js for autoplay styles * Rename generated CSS file
|
It looks like that job skipped an important installation step ( |
|
Restarted the build. no luck. @MaximePlancke could you please try rebase? Thank you |
Codecov Report
@@ Coverage Diff @@
## master #22518 +/- ##
==========================================
- Coverage 85.61% 78.64% -6.98%
==========================================
Files 1556 801 -755
Lines 145994 49721 -96273
==========================================
- Hits 124987 39101 -85886
+ Misses 21007 10620 -10387
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #22518 +/- ##
==========================================
- Coverage 85.61% 78.64% -6.98%
==========================================
Files 1556 801 -755
Lines 145994 49721 -96273
==========================================
- Hits 124987 39101 -85886
+ Misses 21007 10620 -10387
Continue to review full report at Codecov.
|
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
@zhouyx Sorry I think I rebase the wrong way I have all the commits (I am not use to work with fork and must have miss one step). I'll most likely close this PR and reopen one with the updated code |
|
Sounds good. Thanks for letting me know. |
|
@MaximePlancke Thanks for letting us know! 😄 |
Add Didomi documentation and example to AMP related to this comment:
#21693 (comment)
#21752