Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ ESLint Rules: Updates name and comment for enforce-private-props rule #22647

Merged
merged 2 commits into from Jun 24, 2019
Merged

♻️ ESLint Rules: Updates name and comment for enforce-private-props rule #22647

merged 2 commits into from Jun 24, 2019

Conversation

ChrisAntaki
Copy link
Contributor

  • Adds comment describing the rule
  • Updates filename to reflect the scope of the rule

@torch2424 torch2424 mentioned this pull request Jun 18, 2019
Merged
@torch2424
Copy link
Contributor

Triaging to @rsimha , feel free to re-assign 😄

@torch2424 torch2424 requested a review from rsimha June 18, 2019 01:45
@ChrisAntaki
Copy link
Contributor Author

Sounds good, thanks!

@rsimha rsimha requested a review from jridgewell June 18, 2019 21:49
@ChrisAntaki
Copy link
Contributor Author

Just wanted to check in, is this ready to merge? 😄

@jridgewell jridgewell merged commit 275968a into ampproject:master Jun 24, 2019
@jridgewell
Copy link
Contributor

Whoops, forgot to hit the merge button

@ChrisAntaki
Copy link
Contributor Author

ChrisAntaki commented Jun 24, 2019 via email

thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
@ChrisAntaki @jridgewell
♻️ ESLint Rules: Updates name and comment for enforce-private-props r…
b76826e 
…ule (ampproject#22647)

* Adds comment and renames script for better readability

* Updates name & comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@rsimha rsimha Awaiting requested review from rsimha

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChrisAntaki @torch2424 @jridgewell @googlebot