✨ amp-addthis: Adding Open Graph image meta tag as fallback for media prop #22697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
reviewed
Jun 18, 2019
| @@ -31,3 +31,15 @@ export const getDetailsForMeta = meta => { | |||
| content, | |||
| }; | |||
| }; | |||
|
|
|||
| export const getOgImage = doc => { | |||
| const ogImages = doc.head.querySelectorAll('meta[property="og:image"]'); | |||
There was a problem hiding this comment.
since you only care about the first one, please use querySelector instead of querySelectorAll
There was a problem hiding this comment.
Thanks @aghassemi. I just added a new commit that uses querySelector instead.
aghassemi
approved these changes
Jun 19, 2019
matthinegardner
deleted the
matthinegardner/Obtain-OG-image-for-media-property
branch
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For the Pinterest share buttons, AddThis passes a media value to know which image to share. Currently, the image is only passed if the component has the
data-mediaattribute.This feature will use the first Open Graph image meta tag (
og:image) on the page as a fallback, in case thedata-mediaattribute is not present.