Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linker: change default behavior to decorate all subdomains (if can be found) #22712

Merged
merged 2 commits into from Jun 6, 2019

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Jun 5, 2019

Order:

  1. respect destinationDomains
  2. if destinationDomains can't be found. etld+1 can be found: Decorate all subdomain + friendly domain to canonical url
  3. if destinationDomains can't be found. etld+1 can't be found (proxy origin w/o meta tag): Decorate all friendly domains (canonical + source)

Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@zhouyx zhouyx merged commit 5ba5e36 into ampproject:master Jun 6, 2019
@zhouyx zhouyx deleted the all_subdomain branch June 6, 2019 00:48
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants