Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Update dependency prettier to v1.18.2 #22736

Merged
merged 2 commits into from Jul 1, 2019

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jun 6, 2019

This PR contains the following updates:

Package Type Update Change
prettier (source) devDependencies minor 1.17.1 -> 1.18.2

Release Notes

prettier/prettier

v1.18.2

Compare Source

diff

v1.18.1

Compare Source

diff

  • TypeScript: Add trailing comma in tsx, only for arrow function (#​6190 by @​sosukesuzuki)

    Prettier inserts a trailing comma to single type parameter for arrow functions in tsx, since v 1.18. But, this feature inserts a trailing comma to type parameter for besides arrow functions too (e.g, function , interface). This change fix it.

    // Input
    interface Interface1<T> {
      one: "one";
    }
    function function1<T>() {
      return "one";
    }
    
    // Output (Prettier 1.18.0)
    interface Interface1<T,> {
      one: "one";
    }
    function function1<T,>() {
      return "one";
    }
    
    // Output (Prettier 1.18.1)
    interface Interface1<T> {
      one: "one";
    }
    function function1<T>() {
      return "one";
    }
  • Config: Match dotfiles in config overrides (#​6194 by @​duailibe)

    When using overrides in the config file, Prettier was not matching dotfiles (files that start with .). This was fixed in 1.18.1

v1.18.0

Compare Source

diff

🔗 Release Notes


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate-bot renovate-bot changed the title 📦 Update dependency prettier to v1.18.0 📦 Update dependency prettier to v1.18.1 Jun 7, 2019
@renovate-bot renovate-bot changed the title 📦 Update dependency prettier to v1.18.1 📦 Update dependency prettier to v1.18.2 Jun 7, 2019
@renovate-bot renovate-bot changed the title 📦 Update dependency prettier to v1.18.2 📦 Update dependency prettier to v1.18.2 Jun 10, 2019
@renovate-bot renovate-bot changed the title 📦 Update dependency prettier to v1.18.2 📦 Update dependency prettier to v1.18.2 Jun 28, 2019
@renovate-bot renovate-bot changed the title 📦 Update dependency prettier to v1.18.2 📦 Update dependency prettier to v1.18.2 Jul 1, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 1, 2019
@rsimha rsimha added cla: yes and removed cla: no labels Jul 1, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@forking-renovate
Copy link

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@rsimha rsimha merged commit 26d1a91 into ampproject:master Jul 1, 2019
@renovate-bot renovate-bot deleted the renovate/prettier-1.x branch July 1, 2019 20:30
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants