Create skeleton and navigation for FIE ampdocs #22737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
approved these changes
Jun 10, 2019
| return ( | ||
| value.nodeType == /* DOCUMENT_FRAGMENT */ 11 && | ||
| Object.prototype.toString.call(value) === '[object ShadowRoot]' | ||
| ); |
There was a problem hiding this comment.
Do we need this code path? I think we can just check tagName inline and call it a day.
There was a problem hiding this comment.
I think so. It's too difficult to assume that this API will only be called in the polyfill case. It's a reasonable check for any node. Unfortunately, shadow roots have DOCUMENT_FRAGMENT type and thus difficult to determine.
There was a problem hiding this comment.
Yea I mean we could remove this function and just check tagName anywhere we care. Or rename to isPolyfillShadowRoot. Save a few bytes for an unused code path. :)
dvoytenko
force-pushed
the
ampdoc14
branch
3 times, most recently
from
6085a5e
to
3e492ff
Compare
dreamofabear
approved these changes
Jun 24, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Create skeleton and navigation for FIE ampdocs * review fixes * lints * fixes * test fixes * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #22734.