Allow XHR interceptor in local development mode #22746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alabiaga
changed the title
|
cc\ @zhangsu closed the PR with the json handling change and just went the route of doing the json in the response body as a string. Just an FYI, thanks for your review. |
alabiaga
changed the title
alabiaga
changed the title
|
cc\ @fstanis xhrInterceptor example. Will port over same changes to our partner dev code as it'll be cleaner and less noisy of an example. |
|
@choumx Hey Will when you get a chance. Thanks |
dreamofabear
approved these changes
Jun 13, 2019
| sandbox.stub(viewer, 'isTrustedViewer').returns(Promise.resolve(false)); | ||
| interceptionEnabledWin.AMP_DEV_MODE = true; | ||
| sandbox.stub(mode, 'getMode').returns({localDev: true}); |
There was a problem hiding this comment.
You can set test.win.AMP_MODE = {localDev: true}; to avoid the wildcard import.
There was a problem hiding this comment.
The test is actually not enclosed in the scenario test cases which mocks the window obj which is specific to testing native vs polyfill fetch, so this wouldn't work. Thanks for the input though.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* allow intercepting in non development mode * allow xhr intercept in local dev mode. add example for xhr intercept * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to addressing #22600 (comment)
-allow xhr interceptor in local dev mode and not in validation development mode.
-add viewer xhrInterceptor example.