New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Gulp task to convert analytic vendor JS configs to JSON #22769
✨ Gulp task to convert analytic vendor JS configs to JSON #22769
Conversation
cc @zhouyx for review! |
@jonathantyng-amp, before I do a full review, could you help me understand what this task does, how long it takes, and when you typically run it? (Development? Release? What about minified vs. unminified builds?) Our browserify configs are currently fragmented (I'm in the process of trying to consolidate it), so I'd like to avoid further fragmentation if possible. |
@rsimha This gulp task converts the current vendor configs into their own JSON file, placing the files into This task will be run in the release process and runs in ~3 sec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed explanation! Since this is temporary, the code LGTM as written.
🎉 Merged |
…#22769) * add gulp task to generate vendor jsons * finish adding gulp task to convert vendor configs * also generate _fake_.json * add moat canary json * change json spacing to 2 * add comment * add file to forbidden term whitelist * remove unecessary moat canary JSON
Adds a gulp task to convert the analytic vendor JS files to JSON files.
cc @zhouyx for review