amp-truncate-text: support custom actions. #22817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename "expand" slot into "collapsed", since it may be used to do something other than expand. - Rename "collapse" slot into "expanded", since it may be used to do something other than collapse. - Support custom tap actions as well as anchor tags, which will override the default expand/collapse behavior of the "collapsed" and "expanded" slots. - Add a "persistent" slot that is always present. This is useful when you have something like a short description (which may be truncated, depending on available space), but you want to link to another page regardless of truncation.
sparhami
changed the title
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
- Rename "expand" slot into "collapsed", since it may be used to do something other than expand. - Rename "collapse" slot into "expanded", since it may be used to do something other than collapse. - Support custom tap actions as well as anchor tags, which will override the default expand/collapse behavior of the "collapsed" and "expanded" slots. - Add a "persistent" slot that is always present. This is useful when you have something like a short description (which may be truncated, depending on available space), but you want to link to another page regardless of truncation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
other than expand.
other than collapse.
the default expand/collapse behavior of the "collapsed" and "expanded"
slots.
you have something like a short description (which may be truncated,
depending on available space), but you want to link to another page
regardless of truncation.