New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Ads: 1WorldOnline ad integration #22898
✨ Ads: 1WorldOnline ad integration #22898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. few nits. Please also link to your 1wo.md from amp-ad.md. Thank you
ads/1wo.js
Outdated
@@ -0,0 +1,40 @@ | |||
/** | |||
* Copyright 2017 The AMP HTML Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 2019
ads/1wo.md
Outdated
@@ -0,0 +1,40 @@ | |||
<!--- | |||
Copyright 2017 The AMP HTML Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 2019
- Liked to 1wo.md from amp-ad.md
Done |
Thank you @AlexanderKadygrob for adding the support. PR merged. |
* Implemented 1WorldOnline ad integration * - Updated Copyright year - Liked to 1wo.md from amp-ad.md
Implemented 1WorldOnline ad integration