Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Ads: 1WorldOnline ad integration #22898

Merged
merged 2 commits into from Jun 21, 2019

Conversation

AlexanderKadygrob
Copy link
Contributor

Implemented 1WorldOnline ad integration

@AlexanderKadygrob
Copy link
Contributor Author

Can't add reviewers here. Please check, @lannka, @zhouyx

Copy link
Contributor

@zhouyx zhouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. few nits. Please also link to your 1wo.md from amp-ad.md. Thank you

ads/1wo.js Outdated
@@ -0,0 +1,40 @@
/**
* Copyright 2017 The AMP HTML Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2019

ads/1wo.md Outdated
@@ -0,0 +1,40 @@
<!---
Copyright 2017 The AMP HTML Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2019

- Liked to 1wo.md from amp-ad.md
@AlexanderKadygrob
Copy link
Contributor Author

Looks great. few nits. Please also link to your 1wo.md from amp-ad.md. Thank you

Done

@zhouyx zhouyx merged commit b3bf2eb into ampproject:master Jun 21, 2019
@zhouyx
Copy link
Contributor

zhouyx commented Jun 21, 2019

Thank you @AlexanderKadygrob for adding the support. PR merged.

thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
* Implemented 1WorldOnline ad integration

* - Updated Copyright year
- Liked to 1wo.md from amp-ad.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants