Fix race and speed up amp-list/amp-bind interaction #22938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 19, 2019 21:00
5 tasks
dreamofabear
changed the title
|
/to @jridgewell |
dreamofabear
commented
Jun 21, 2019
| Services.bindForDocOrNull(this.element).then(bind => { | ||
| if (bind) { | ||
| return bind.scanAndApply([this.element], [this.element]); | ||
| return bind.rescan([this.element], [this.element], {'apply': true}); |
There was a problem hiding this comment.
@cvializ I think this was broken for awhile. 🤷♂
There was a problem hiding this comment.
Time to write an integration test 😬
jridgewell
approved these changes
Jun 24, 2019
| // Scan `addedElements` and their children for elements with bindings. | ||
| const elementsToScan = addedElements.slice(); | ||
| const elementsToScan = addedElements.filter(el => | ||
| el.hasAttribute('i-amphtml-binding') |
There was a problem hiding this comment.
Why are you filtering here?
There was a problem hiding this comment.
Minor optimization. We only want to scan elements with [i-amphtml-binding] attribute, and elements in addedElements may not have it.
scanElement_() iterates over an element's attributes, so this should be a small perf win.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Refactor scanAndApply and rename to rescan. * Fix types. * Remove old skip. * Use string keys to be safe, add early returns. * rescan() should wait for macros in fast mode. * Fix a few bugs. * Fix tests, clean up. * Lint. * Fix types. * More readability changes. * Skip rescan in amp-list if elements have no binding attributes. * Add amp-list tests (WIP). * Only skip scan of children, update example. * Better comments. * Add tests for new Bind.rescan options. * Improve perf of binding limit detection and early-out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22341, partial for #21901.
amp-list[binding=refresh]and amp-bind's initial DOM scan.Bind.rescanin amp-list if new children have no binding marker attributes ([i-amphtml-binding]).Bind.rescanto only wait for a small part of Bind's initialization.Bind.rescanto fix/support amp-date-picker's usage.