✅ Add e2e test for <amp-lightbox-gallery>
#22964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simply opens/closes the gallery to make sure nothing major is broken.
cvializ
reviewed
Jun 24, 2019
| @@ -52,7 +52,7 @@ <h2>Open with expanded caption</h2> | |||
| <amp-img | |||
| on="tap:lg.open(expandDescription = true)" | |||
| lightbox="caption" | |||
| src="https://picsum.photos/300/200" | |||
There was a problem hiding this comment.
nice, local images are probably a better idea
| 'http://localhost:8000/test/manual/amp-lightbox-gallery-launch.amp.html', | ||
| initialRect: {width: pageWidth, height: pageHeight}, | ||
| // TODO(sparhami) Get this working in other environments. | ||
| environments: ['single'], |
There was a problem hiding this comment.
what happens when it runs in the others? is it something to do with screen sizing or is it something else?
There was a problem hiding this comment.
I didn't dig too deeply, but when I ran locally, the page didn't show up in the viewer or shadow environments. I think it could be something about my local config though.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
This simply opens/closes the gallery to make sure nothing major is broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a single test for now, will work on adding more tests later.