Show the story bookend in vertical rendering. #22976
Conversation
|
Do we want to render the bookend before the page attachments? I thought we wanted it at the end? Also somewhat related: the page attachment in the bot view is showing multiple "x" buttons, we might want to fix that.
|
| @@ -1820,6 +1820,8 @@ export class AmpStory extends AMP.BaseElement { | |||
| 'amp-story-page amp-story-page-attachment' | |||
| ); | |||
|
|
|||
| this.initializeBookend_().then(() => this.showBookend_()); | |||
There was a problem hiding this comment.
Could having this outside of the this.vsync_.mutate below cause race conditions that would result in rendering the bookend sometimes before the page attachments, and sometimes after?
There was a problem hiding this comment.
The initializeBookend_ method creates the bookend synchronously, if it didn't exist yet. It'll always be before the page attachments
|
Product decision was to render the page attachments last. I filed #22982 for the close buttons issue, that's specific to the visual diff tests |
Show the story bookend in vertical rendering.