Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Criteo support to amp-ad #2299

Merged
merged 1 commit into from Mar 2, 2016

Conversation

Projects
None yet
3 participants
@nicolastruchi
Copy link
Contributor

commented Feb 26, 2016

add support to amp-ad for the Criteo type.

Intent to implement: #2296

@googlebot

This comment has been minimized.

Copy link

commented Feb 26, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
limitations under the License.
-->

# Criteo

This comment has been minimized.

Copy link
@cramforce

cramforce Feb 26, 2016

Member

Please add a link to your own docs.

This comment has been minimized.

Copy link
@nicolastruchi

nicolastruchi Feb 26, 2016

Author Contributor

done


# Criteo

## Example

This comment has been minimized.

Copy link
@cramforce

cramforce Feb 26, 2016

Member

Please also add a link into the main amp-ad doc into the list of supported ad networks.

This comment has been minimized.

Copy link
@nicolastruchi

nicolastruchi Feb 26, 2016

Author Contributor

Isn't this covered in the change to builtins/amp-ad.md?

This comment has been minimized.

Copy link
@cramforce

cramforce Feb 26, 2016

Member

Missed it. All good!

@cramforce

View changes

ads/_config.js Outdated
@@ -51,6 +52,10 @@ export const adPreconnect = {
'https://trc.taboola.com',
'https://images.taboola.com',
],
criteo: [
'https://static.criteo.net',

This comment has been minimized.

Copy link
@cramforce

cramforce Feb 26, 2016

Member

No need to repeat host from prefetching (we also preconnect in browser where we can't prefetch).

@nicolastruchi nicolastruchi force-pushed the criteo-forks:master branch Feb 29, 2016

@cramforce

This comment has been minimized.

Copy link
Member

commented Mar 1, 2016

This is good to go. Please rebase and push again. Thanks!

@nicolastruchi nicolastruchi force-pushed the criteo-forks:master branch to 2d3fbb5 Mar 2, 2016

@nicolastruchi

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2016

I signed it!

Signed with Corporate CLA for the company: Criteo SA

@cramforce cramforce added LGTM and removed NEEDS REVIEW labels Mar 2, 2016

cramforce added a commit that referenced this pull request Mar 2, 2016

Merge pull request #2299 from criteo-forks/master
Add Criteo support to amp-ad

@cramforce cramforce merged commit d528074 into ampproject:master Mar 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.