Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉Fix invalid and unnecessary code block quotes in docs #22998

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

tharders
Copy link
Contributor

The amp-mustache documentation contains unnecessary code block quotes that normally will be rendered, but should not.
As seen on github the quotes after the {{#section}} block are shown:
https://github.com/ampproject/amphtml/blob/master/extensions/amp-mustache/amp-mustache.md#syntax
On amp.dev the quotes are currently not shown, but this will change as we are about to change the preprocessing of the imported markdown files from amphtml.
So please apply this PR to remove the unnecessary quotes.

@cvializ cvializ self-requested a review June 25, 2019 14:59
Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@mrjoro mrjoro merged commit 70d427d into ampproject:master Aug 8, 2019
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants