Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all native HTML inputs for dirtiness check #23037

Merged
merged 1 commit into from Jun 27, 2019

Conversation

xrav3nz
Copy link
Contributor

@xrav3nz xrav3nz commented Jun 26, 2019

This includes:

  • text fields
  • textareas
  • radio buttons
  • checkboxes
  • dropdown menus

Part of #22534.

/cc @GoTcWang @cvializ

This includes:
- text type inputs
- radio buttons
- checkboxes
- dropdown menus
- textareas
Copy link
Contributor

@GoTcWang GoTcWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cvializ cvializ merged commit 55c5928 into ampproject:master Jun 27, 2019
@xrav3nz xrav3nz deleted the feature/form-dirtiness-all-input branch June 27, 2019 14:00
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
This includes:
- text type inputs
- radio buttons
- checkboxes
- dropdown menus
- textareas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants