Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗🐛 Silence autoprefixer deprecation warning by renaming browsers to overrideBrowserslist #23107

Merged
merged 1 commit into from Jun 28, 2019
Merged

🏗🐛 Silence autoprefixer deprecation warning by renaming browsers to overrideBrowserslist #23107

merged 1 commit into from Jun 28, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jun 28, 2019

autoprefixer added a warning for a potentially breaking change in its new version by renaming the browsers field. See #22652 and postcss/autoprefixer#1226.

  Replace Autoprefixer browsers option to Browserslist config.
  Use browserslist key in package.json or .browserslistrc file.
  Using browsers option cause some error. Browserslist config 
  can be used for Babel, Autoprefixer, postcss-normalize and other tools.
  If you really need to use option, rename it to overrideBrowserslist.
  Learn more at:
  https://github.com/browserslist/browserslist#readme
  https://twitter.com/browserslist

This PR renames browsers to overrideBrowserslist as recommended in the warning.

@rsimha rsimha self-assigned this Jun 28, 2019
@rsimha rsimha merged commit 7b4452a into ampproject:master Jun 28, 2019
@rsimha rsimha deleted the 2019-06-28-AutoprefixerWarning branch June 28, 2019 22:14
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants