✨ amp-ad New integrating ad networks support type: streamrail

[gershman]

Implemented streamrail ad integration

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[gershman]

I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[mrjoro]

/cc @ampproject/wg-ads @lannka

[gershman]

@lannka Hi, I see that the Travis check: https://travis-ci.org/ampproject/amphtml/jobs/555752095 failed because of ".then" is forbidden. We take care of this by implementation our on pollyfill so it will support promises.

[lannka]

@gershman that sounds good if you have polyfill in your own code, we can make an exemption for your case.

However, to our past experience, it will be better for you to have less logic in AMP repo. I suggest you move code to your own custom JS, and have only code that handles configuration in AMP. That way you have less dependency on our release cycles to update/fix things.

That way, you probably also don't need to use Promise in AMP.

[gershman]

@lannka hi, I updated the code so it won't use Promise anymore.
I see that am still getting some tests fails ( tests/e2e), but don't which tests failed or the reason why. Any idea?

[lannka]

the e2e test failure was irrelevant