Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COOKIE macro support in linker #23207

Merged
merged 1 commit into from Jul 8, 2019
Merged

COOKIE macro support in linker #23207

merged 1 commit into from Jul 8, 2019

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Jul 8, 2019 •
edited

This is to follow up #22815

As agreed offline, I am duplicating the binding declaration to support COOKIE in Linker. Once we pass element to variable service, or FIE has its own instance of ampdoc service. This can be removed.

@zhouyx zhouyx requested review from lannka and calebcordry July 8, 2019 20:19
@zhouyx
Copy link
Contributor Author

zhouyx commented Jul 8, 2019

@lannka @calebcordry
Friendly ping. No rush, but it'd be great if I can get this change by tomorrow morning. So it will unblock @zikas's work. Thank you for the review : )

@zhouyx zhouyx merged commit df20838 into ampproject:master Jul 8, 2019
@zhouyx
Copy link
Contributor Author

zhouyx commented Jul 8, 2019

Thank you all!

@zhouyx zhouyx deleted the cookie-linker branch July 8, 2019 22:53
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
@zhouyx
cookie support in linker (ampproject#23207)
bab70b4
@micajuine-ho micajuine-ho mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

@calebcordry calebcordry calebcordry approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouyx @lannka @calebcordry @googlebot