Story desktop GPU memory optimization so videos play smoothly. #23240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
approved these changes
Jul 9, 2019
|
|
|
FYI @hongwei1990 since we added (or, drastically increased) this when we removed the background images |
newmuis
approved these changes
Jul 10, 2019
newmuis
reviewed
Jul 10, 2019
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
…oject#23240) * Performance optimization + getting the videos to play. * border-radius + box-shadow properties.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
…oject#23240) * Performance optimization + getting the videos to play. * border-radius + box-shadow properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPU memory used by our desktop three panels experience was so high that on some computers, the hardware-accelerated video decoding was stuttering, resulting on videos not playing.
(Hardware accelerated video decoding uses GPU, not CPU, which is why videos were playing smoothly when we were disabling it).
This fix gets all videos to play as smooth as expected in this desktop three panels layout, but as a nice side effect gets the overall experience much much faster.
Removing this
box-shadowhas no visible effect, since we removed the background images.One line fix but really interesting performance improvements:
Fixes #23184