Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Silence / fix known warnings that appear when gulp check-types detects an error #23242

Merged
merged 1 commit into from Jul 10, 2019
Merged

🏗 Silence / fix known warnings that appear when gulp check-types detects an error #23242

merged 1 commit into from Jul 10, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jul 9, 2019

When gulp check-types detects a real error, it's accompanied by hundreds of warnings due to known issues in the code. This PR fixes / silences those warnings so that only the errors that need to be acted on are displayed on the screen.

@rsimha rsimha requested review from alanorozco and cvializ July 9, 2019 22:18
@rsimha rsimha self-assigned this Jul 9, 2019
@rsimha
Copy link
Contributor Author

rsimha commented Jul 9, 2019

Warnings fixed by this PR:

build-system/amp.extern.js:307: WARNING - name RRule is not defined in the externs.
RRule.prototype.before = function(unusedDt, unusedInc) {};
^^^^^

build-system/amp.extern.js:313: WARNING - name RRule is not defined in the externs.
RRule.prototype.after = function(unusedDt, unusedInc) {};
^^^^^

Warnings silenced by this PR:

extensions/amp-subscriptions/0.1/amp-subscriptions.js:50: WARNING - Failed to load module "../amp-access/0.1/access-vars"
 * @implements {../amp-access/0.1/access-vars.AccessVars}
                ^

node_modules/rrule/dist/esm/src/index.js:16: 
Originally at:
node_modules/rrule/src/index.ts:17: WARNING - Failed to load module "./rrule"

node_modules/rrule/dist/esm/src/index.js:17: 
Originally at:
node_modules/rrule/src/index.ts:18: WARNING - Failed to load module "./rruleset"

node_modules/rrule/dist/esm/src/index.js:18: 
Originally at:
node_modules/rrule/src/index.ts:19: WARNING - Failed to load module "./rrulestr"

node_modules/rrule/dist/esm/src/index.js:19: 
Originally at:
node_modules/rrule/src/index.ts:20: WARNING - Failed to load module "./types"

node_modules/rrule/dist/esm/src/index.js:20: 
Originally at:
node_modules/rrule/src/index.ts:21: WARNING - Failed to load module "./weekday"

third_party/subscriptions-project/swg.js:2466: WARNING - Failed to load module "../proto/api_messages"
   * @param {!../proto/api_messages.Message} request
              ^

third_party/subscriptions-project/swg.js:3121: WARNING - Failed to load module "../model/doc"
 * @param {!../model/doc.Doc} doc The document object.
            ^

third_party/subscriptions-project/swg.js:3571: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:3573: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.SmartButtonOptions} options
              ^

third_party/subscriptions-project/swg.js:3577: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:3586: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:3597: WARNING - Failed to load module "../api/subscriptions"
    /** @private {!../api/subscriptions.SmartButtonOptions} */
                   ^

third_party/subscriptions-project/swg.js:3720: WARNING - Failed to load module "../model/doc"
   * @param {!../model/doc.Doc} doc
              ^

third_party/subscriptions-project/swg.js:3723: WARNING - Failed to load module "../model/doc"
    /** @private @const {!../model/doc.Doc} */
                          ^

third_party/subscriptions-project/swg.js:3750: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.ButtonOptions|function()} optionsOrCallback
              ^

third_party/subscriptions-project/swg.js:3761: WARNING - Failed to load module "../api/subscriptions"
   * @param {../api/subscriptions.ButtonOptions|function()} optionsOrCallback
             ^

third_party/subscriptions-project/swg.js:3766: WARNING - Failed to load module "../api/subscriptions"
    const options = /** @type {!../api/subscriptions.ButtonOptions} */
                                ^

third_party/subscriptions-project/swg.js:3783: WARNING - Failed to load module "../api/subscriptions"
   * @param {../api/subscriptions.ButtonOptions|../api/subscriptions.SmartButtonOptions|function()} optionsOrCallback
             ^

third_party/subscriptions-project/swg.js:3783: WARNING - Failed to load module "../api/subscriptions"
   * @param {../api/subscriptions.ButtonOptions|../api/subscriptions.SmartButtonOptions|function()} optionsOrCallback
                                                ^

third_party/subscriptions-project/swg.js:3784: WARNING - Failed to load module "../api/subscriptions"
   * @return {!../api/subscriptions.ButtonOptions|!../api/subscriptions.SmartButtonOptions}
               ^

third_party/subscriptions-project/swg.js:3784: WARNING - Failed to load module "../api/subscriptions"
   * @return {!../api/subscriptions.ButtonOptions|!../api/subscriptions.SmartButtonOptions}
                                                   ^

third_party/subscriptions-project/swg.js:3788: WARNING - Failed to load module "../api/subscriptions"
    const options = /** @type {!../api/subscriptions.ButtonOptions|!../api/subscriptions.SmartButtonOptions} */
                                ^

third_party/subscriptions-project/swg.js:3788: WARNING - Failed to load module "../api/subscriptions"
    const options = /** @type {!../api/subscriptions.ButtonOptions|!../api/subscriptions.SmartButtonOptions} */
                                                                    ^

third_party/subscriptions-project/swg.js:3801: WARNING - Failed to load module "../api/subscriptions"
   * @param {?../api/subscriptions.ButtonOptions|?../api/subscriptions.SmartButtonOptions|function()} optionsOrCallback
              ^

third_party/subscriptions-project/swg.js:3801: WARNING - Failed to load module "../api/subscriptions"
   * @param {?../api/subscriptions.ButtonOptions|?../api/subscriptions.SmartButtonOptions|function()} optionsOrCallback
                                                  ^

third_party/subscriptions-project/swg.js:3814: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:3816: WARNING - Failed to load module "../api/subscriptions"
   * @param {../api/subscriptions.SmartButtonOptions|function()} optionsOrCallback
             ^

third_party/subscriptions-project/swg.js:3821: WARNING - Failed to load module "../api/subscriptions"
    const options = /** @type {!../api/subscriptions.SmartButtonOptions} */
                                ^

third_party/subscriptions-project/swg.js:3881: WARNING - Failed to load module "../api/entitlements"
   * @param {function(!Promise<!../api/entitlements.Entitlements>)} callback
                                ^

third_party/subscriptions-project/swg.js:3888: WARNING - Failed to load module "../api/entitlements"
   * @param {!Promise<!../api/entitlements.Entitlements>} promise
                       ^

third_party/subscriptions-project/swg.js:3904: WARNING - Failed to load module "../api/subscriptions"
   * @param {function(!../api/subscriptions.LoginRequest)} callback
                       ^

third_party/subscriptions-project/swg.js:3911: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.LoginRequest} request
              ^

third_party/subscriptions-project/swg.js:3981: WARNING - Failed to load module "../api/subscribe-response"
   * @param {function(!Promise<!../api/subscribe-response.SubscribeResponse>)} callback
                                ^

third_party/subscriptions-project/swg.js:3988: WARNING - Failed to load module "../api/subscribe-response"
   * @param {function(!Promise<!../api/subscribe-response.SubscribeResponse>)} callback
                                ^

third_party/subscriptions-project/swg.js:3995: WARNING - Failed to load module "../api/subscribe-response"
   * @param {!Promise<!../api/subscribe-response.SubscribeResponse>} responsePromise
                       ^

third_party/subscriptions-project/swg.js:4005: WARNING - Failed to load module "../api/subscribe-response"
   * @param {!Promise<!../api/subscribe-response.SubscribeResponse>} responsePromise
                       ^

third_party/subscriptions-project/swg.js:4156: WARNING - Failed to load module "./dialog"
   * @param {!./dialog.Dialog} unusedDialog
              ^

third_party/subscriptions-project/swg.js:4261: WARNING - Failed to load module "../components/activities"
 * @param {!../components/activities.ActivityPortDef} port
            ^

third_party/subscriptions-project/swg.js:4312: WARNING - Failed to load module "../components/activities"
   * @param {!../components/activities.ActivityPorts} activityPorts
              ^

third_party/subscriptions-project/swg.js:4338: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:4353: WARNING - Failed to load module "../components/activities"
    /** @private {?../components/activities.ActivityIframePort} */
                   ^

third_party/subscriptions-project/swg.js:4399: WARNING - Failed to load module "../components/activities"
   * @param {!../components/activities.ActivityIframePort} port
              ^

third_party/subscriptions-project/swg.js:4400: WARNING - Failed to load module "../components/dialog"
   * @param {!../components/dialog.Dialog} dialog
              ^

third_party/subscriptions-project/swg.js:4415: WARNING - Failed to load module "../components/activities"
   * @return {!Promise<!../components/activities.ActivityIframePort>}
                        ^

third_party/subscriptions-project/swg.js:5566: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:5567: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.SubscriptionRequest|string} skuOrSubscriptionRequest
              ^

third_party/subscriptions-project/swg.js:5568: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.ProductType} productType
              ^

third_party/subscriptions-project/swg.js:5574: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:5577: WARNING - Failed to load module "./pay-client"
    /** @private @const {!./pay-client.PayClient} */
                          ^

third_party/subscriptions-project/swg.js:5580: WARNING - Failed to load module "../model/page-config"
    /** @private @const {!../model/page-config.PageConfig} */
                          ^

third_party/subscriptions-project/swg.js:5583: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:5586: WARNING - Failed to load module "../api/subscriptions"
    /** @private @const {!../api/subscriptions.SubscriptionRequest} */
                          ^

third_party/subscriptions-project/swg.js:5594: WARNING - Failed to load module "../runtime/analytics-service"
    /** @private @const {!../runtime/analytics-service.AnalyticsService} */
                          ^

third_party/subscriptions-project/swg.js:5647: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:5671: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:5677: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:5680: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:5683: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:5695: WARNING - Failed to load module "../runtime/analytics-service"
    /** @private @const {!../runtime/analytics-service.AnalyticsService} */
                          ^

third_party/subscriptions-project/swg.js:5770: WARNING - Failed to load module "./deps"
 * @param {!./deps.DepsDef} deps
            ^

third_party/subscriptions-project/swg.js:5791: WARNING - Failed to load module "./deps"
 * @param {!./deps.DepsDef} deps
            ^

third_party/subscriptions-project/swg.js:5868: WARNING - Failed to load module "./deps"
 * @param {!./deps.DepsDef} deps
            ^

third_party/subscriptions-project/swg.js:5870: WARNING - Failed to load module "../api/entitlements"
 * @return {?../api/entitlements.Entitlements}
             ^

third_party/subscriptions-project/swg.js:5913: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:5914: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.OffersRequest|undefined} options
              ^

third_party/subscriptions-project/swg.js:5917: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:5920: WARNING - Failed to load module "../api/subscriptions"
    /** @private @const {!../api/subscriptions.OffersRequest|undefined} */
                          ^

third_party/subscriptions-project/swg.js:5926: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:5929: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:6009: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:6010: WARNING - Failed to load module "../api/deferred-account-creation"
   * @param {?../api/deferred-account-creation.DeferredAccountCreationRequest} options
              ^

third_party/subscriptions-project/swg.js:6013: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:6019: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:6022: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:6031: WARNING - Failed to load module "../api/deferred-account-creation"
    /** @type {!../api/deferred-account-creation.DeferredAccountCreationRequest} */
                ^

third_party/subscriptions-project/swg.js:6036: WARNING - Failed to load module "../api/deferred-account-creation"
    /** @private @const {!../api/deferred-account-creation.DeferredAccountCreationRequest} */
                          ^

third_party/subscriptions-project/swg.js:6387: WARNING - Failed to load module "../model/doc"
   * @param {!../model/doc.Doc} doc
              ^

third_party/subscriptions-project/swg.js:6391: WARNING - Failed to load module "../model/doc"
    /** @private @const {!../model/doc.Doc} */
                          ^

third_party/subscriptions-project/swg.js:6729: WARNING - Failed to load module "../model/doc"
   * @param {!../model/doc.Doc} doc
              ^

third_party/subscriptions-project/swg.js:6734: WARNING - Failed to load module "../model/doc"
    /** @private @const {!../model/doc.Doc} */
                          ^

third_party/subscriptions-project/swg.js:6757: WARNING - Failed to load module "./view"
    /** @private {?./view.View} */
                   ^

third_party/subscriptions-project/swg.js:6766: WARNING - Failed to load module "./view"
    /** @private {?./view.View} */
                   ^

third_party/subscriptions-project/swg.js:6905: WARNING - Failed to load module "./view"
  /** @return {?./view.View} */
                ^

third_party/subscriptions-project/swg.js:6912: WARNING - Failed to load module "./view"
   * @param {!./view.View} view
              ^

third_party/subscriptions-project/swg.js:6963: WARNING - Failed to load module "./view"
   * @param {!./view.View} view
              ^

third_party/subscriptions-project/swg.js:7149: WARNING - Failed to load module "../model/doc"
   * @param {!../model/doc.Doc} doc
              ^

third_party/subscriptions-project/swg.js:7152: WARNING - Failed to load module "../model/doc"
    /** @private @const {!../model/doc.Doc} */
                          ^

third_party/subscriptions-project/swg.js:7191: WARNING - Failed to load module "./view"
   * @param {!./view.View} view
              ^

third_party/subscriptions-project/swg.js:7208: WARNING - Failed to load module "./view"
   * @param {?./view.View} view
              ^

third_party/subscriptions-project/swg.js:7294: WARNING - Failed to load module "../runtime/deps"
   * @param {!../runtime/deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:7300: WARNING - Failed to load module "../model/doc"
    /** @private @const {!../model/doc.Doc} */
                          ^

third_party/subscriptions-project/swg.js:7303: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:7444: WARNING - Failed to load module "../model/page-config"
   * @param {!../model/page-config.PageConfig} pageConfig
              ^

third_party/subscriptions-project/swg.js:7445: WARNING - Failed to load module "./fetcher"
   * @param {!./fetcher.Fetcher} fetcher
              ^

third_party/subscriptions-project/swg.js:7446: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:7452: WARNING - Failed to load module "../model/page-config"
    /** @private @const {!../model/page-config.PageConfig} */
                          ^

third_party/subscriptions-project/swg.js:7458: WARNING - Failed to load module "./fetcher"
    /** @private @const {!./fetcher.Fetcher} */
                          ^

third_party/subscriptions-project/swg.js:7461: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:7476: WARNING - Failed to load module "./storage"
    /** @private @const {!./storage.Storage} */
                          ^

third_party/subscriptions-project/swg.js:7479: WARNING - Failed to load module "../runtime/analytics-service"
    /** @private @const {!../runtime/analytics-service.AnalyticsService} */
                          ^

third_party/subscriptions-project/swg.js:7482: WARNING - Failed to load module "../api/subscriptions"
    /** @private @const {!../api/subscriptions.Config} */
                          ^

third_party/subscriptions-project/swg.js:8317: WARNING - Failed to load module "../utils/xhr"
    const init = /** @type {!../utils/xhr.FetchInitDef} */ ({
                             ^

third_party/subscriptions-project/swg.js:8348: WARNING - Failed to load module "../model/doc"
   * @param {!../model/doc.Doc} doc
              ^

third_party/subscriptions-project/swg.js:8351: WARNING - Failed to load module "../model/doc"
    /** @private @const {!../model/doc.Doc} */
                          ^

third_party/subscriptions-project/swg.js:8458: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:8461: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:8464: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:8467: WARNING - Failed to load module "../model/page-config"
    /** @private @const {!../model/page-config.PageConfig} */
                          ^

third_party/subscriptions-project/swg.js:8470: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:8501: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:8506: WARNING - Failed to load module "../components/activities"
     * @param {!../components/activities.ActivityPortDef} port
                ^

third_party/subscriptions-project/swg.js:8529: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:8536: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:8539: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:8542: WARNING - Failed to load module "./entitlements-manager"
    /** @private @const {!./entitlements-manager.EntitlementsManager} */
                          ^

third_party/subscriptions-project/swg.js:8545: WARNING - Failed to load module "./callbacks"
    /** @private @const {!./callbacks.Callbacks} */
                          ^

third_party/subscriptions-project/swg.js:8621: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:8622: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.SaveSubscriptionRequestCallback} callback
              ^

third_party/subscriptions-project/swg.js:8628: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:8631: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:8634: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:8637: WARNING - Failed to load module "../api/subscriptions"
    /** @private {!../api/subscriptions.SaveSubscriptionRequestCallback} */
                   ^

third_party/subscriptions-project/swg.js:8640: WARNING - Failed to load module "../api/subscriptions"
    /** @private {?Promise<!../api/subscriptions.SaveSubscriptionRequest>} */
                            ^

third_party/subscriptions-project/swg.js:8651: WARNING - Failed to load module "../api/subscriptions"
   * @return {?Promise<!../api/subscriptions.SaveSubscriptionRequest>}
                        ^

third_party/subscriptions-project/swg.js:8784: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:8787: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:8793: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:8796: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:8863: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:8866: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:8872: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:8875: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:12113: WARNING - Failed to load module "../components/activities"
   * @param {!../components/activities.ActivityPorts} activityPorts
              ^

third_party/subscriptions-project/swg.js:12114: WARNING - Failed to load module "../components/dialog-manager"
   * @param {!../components/dialog-manager.DialogManager} dialogManager
              ^

third_party/subscriptions-project/swg.js:12125: WARNING - Failed to load module "../utils/preconnect"
   * @param {!../utils/preconnect.Preconnect} pre
              ^

third_party/subscriptions-project/swg.js:12168: WARNING - Failed to load module "../components/activities"
   * @param {!../components/activities.ActivityPorts} activityPorts
              ^

third_party/subscriptions-project/swg.js:12169: WARNING - Failed to load module "../components/dialog-manager"
   * @param {!../components/dialog-manager.DialogManager} dialogManager
              ^

third_party/subscriptions-project/swg.js:12174: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:12176: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:12207: WARNING - Failed to load module "../components/activities"
   * @param {!../components/activities.ActivityPortDef} port
              ^

third_party/subscriptions-project/swg.js:12222: WARNING - Failed to load module "../utils/xhr"
        const init = /** @type {!../utils/xhr.FetchInitDef} */ ({
                                 ^

third_party/subscriptions-project/swg.js:12254: WARNING - Failed to load module "../components/activities"
   * @param {!../components/activities.ActivityPorts} activityPorts
              ^

third_party/subscriptions-project/swg.js:12259: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:12561: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:12565: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:12571: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:12574: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:12636: WARNING - Failed to load module "../model/page-config"
   * @param {!../model/page-config.PageConfig} config
              ^

third_party/subscriptions-project/swg.js:12637: WARNING - Failed to load module "./fetcher"
   * @param {!./fetcher.Fetcher} fetcher
              ^

third_party/subscriptions-project/swg.js:12640: WARNING - Failed to load module "../model/page-config"
    /** @private @const {!../model/page-config.PageConfig} */
                          ^

third_party/subscriptions-project/swg.js:12643: WARNING - Failed to load module "./fetcher"
    /** @private @const {!./fetcher.Fetcher} */
                          ^

third_party/subscriptions-project/swg.js:12649: WARNING - Failed to load module "../api/offer"
   * @return {!Promise<!Array<!../api/offer.Offer>>}
                               ^

third_party/subscriptions-project/swg.js:12661: WARNING - Failed to load module "../api/offer"
   * @return {!Promise<!Array<!../api/offer.Offer>>}
                               ^

third_party/subscriptions-project/swg.js:12705: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:12706: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.OffersRequest|undefined} options
              ^

third_party/subscriptions-project/swg.js:12709: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:12715: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:12718: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:12788: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:12789: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.OffersRequest|undefined} options
              ^

third_party/subscriptions-project/swg.js:12793: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:12796: WARNING - Failed to load module "../api/subscriptions"
    /** @private @const {!../api/subscriptions.OffersRequest|undefined} */
                          ^

third_party/subscriptions-project/swg.js:12799: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:12802: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:12868: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:12869: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.OffersRequest=} options
              ^

third_party/subscriptions-project/swg.js:12873: WARNING - Failed to load module "./deps"
    /** @private @const {!./deps.DepsDef} */
                          ^

third_party/subscriptions-project/swg.js:12876: WARNING - Failed to load module "../api/subscriptions"
    /** @private @const {!../api/subscriptions.OffersRequest|undefined} */
                          ^

third_party/subscriptions-project/swg.js:12882: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:12885: WARNING - Failed to load module "../components/dialog-manager"
    /** @private @const {!../components/dialog-manager.DialogManager} */
                          ^

third_party/subscriptions-project/swg.js:13223: WARNING - Failed to load module "./deps"
   * @param {!./deps.DepsDef} deps
              ^

third_party/subscriptions-project/swg.js:13227: WARNING - Failed to load module "../model/doc"
    /** @private @const {!../model/doc.Doc} */
                          ^

third_party/subscriptions-project/swg.js:13230: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:13263: WARNING - Failed to load module "../api/client-event-manager-api"
    /** @private @const {!../api/client-event-manager-api.ClientEventManagerApi} */
                          ^

third_party/subscriptions-project/swg.js:13364: WARNING - Failed to load module "../components/activities"
   * @return {!Promise<!../components/activities.ActivityIframePort>}
                        ^

third_party/subscriptions-project/swg.js:13401: WARNING - Failed to load module "../api/client-event-manager-api"
   * @param {!../api/client-event-manager-api.ClientEvent} event
              ^

third_party/subscriptions-project/swg.js:13422: WARNING - Failed to load module "../proto/api_messages"
   * @param {!../proto/api_messages.AnalyticsEvent} eventTypeIn
              ^

third_party/subscriptions-project/swg.js:13447: WARNING - Failed to load module "../api/client-event-manager-api"
   * @param {!../api/client-event-manager-api.ClientEvent} event
              ^

third_party/subscriptions-project/swg.js:13560: WARNING - Failed to load module "../api/client-event-manager-api"
   * @param {!../api/client-event-manager-api.ClientEventManagerApi} eventManager
              ^

third_party/subscriptions-project/swg.js:13630: WARNING - Failed to load module "../utils/xhr"
    const init = /** @type {!../utils/xhr.FetchInitDef} */ ({
                             ^

third_party/subscriptions-project/swg.js:13654: WARNING - Failed to load module "../utils/xhr"
    const init = /** @type {!../utils/xhr.FetchInitDef} */ ({
                             ^

third_party/subscriptions-project/swg.js:13674: WARNING - Failed to load module "../api/client-event-manager-api"
   * @param {!../api/client-event-manager-api.ClientEvent} event
              ^

third_party/subscriptions-project/swg.js:13699: WARNING - Failed to load module "../api/propensity-api"
   * @return {!../api/propensity-api.PropensityScore}
               ^

third_party/subscriptions-project/swg.js:13703: WARNING - Failed to load module "../api/propensity-api"
        /** @type {!../api/propensity-api.PropensityScore} */ ({});
                    ^

third_party/subscriptions-project/swg.js:13706: WARNING - Failed to load module "../api/propensity-api"
        /** @type {!../api/propensity-api.PropensityScore} */ ({
                    ^

third_party/subscriptions-project/swg.js:13727: WARNING - Failed to load module "../api/propensity-api"
            /** @type {!../api/propensity-api.PropensityScore} */ ({
                        ^

third_party/subscriptions-project/swg.js:13736: WARNING - Failed to load module "../api/propensity-api"
        defaultScore = /** @type {!../api/propensity-api.PropensityScore} */ ({
                                   ^

third_party/subscriptions-project/swg.js:13743: WARNING - Failed to load module "../api/propensity-api"
      defaultScore = /** @type {!../api/propensity-api.PropensityScore} */ ({
                                 ^

third_party/subscriptions-project/swg.js:13753: WARNING - Failed to load module "../api/propensity-api"
   * @return {?Promise<../api/propensity-api.PropensityScore>}
                       ^

third_party/subscriptions-project/swg.js:13757: WARNING - Failed to load module "../utils/xhr"
    const init = /** @type {!../utils/xhr.FetchInitDef} */ ({
                             ^

third_party/subscriptions-project/swg.js:13802: WARNING - Failed to load module "../model/page-config"
   * @param {!../model/page-config.PageConfig} pageConfig
              ^

third_party/subscriptions-project/swg.js:13803: WARNING - Failed to load module "../api/client-event-manager-api"
   * @param {!../api/client-event-manager-api.ClientEventManagerApi} eventManager
              ^

third_party/subscriptions-project/swg.js:13812: WARNING - Failed to load module "../api/client-event-manager-api"
    /** @private @const {!../api/client-event-manager-api.ClientEventManagerApi} */
                          ^

third_party/subscriptions-project/swg.js:13993: WARNING - Failed to load module "../api/client-event-manager-api"
 * @param {!../api/client-event-manager-api.ClientEvent} event
            ^

third_party/subscriptions-project/swg.js:14021: WARNING - Failed to load module "../api/client-event-manager-api"
/** @implements {../api/client-event-manager-api.ClientEventManagerApi} */
                 ^

third_party/subscriptions-project/swg.js:14028: WARNING - Failed to load module "../api/client-event-manager-api"
    /** @private {!Array<function(!../api/client-event-manager-api.ClientEvent)>} */
                                   ^

third_party/subscriptions-project/swg.js:14031: WARNING - Failed to load module "../api/client-event-manager-api"
    /** @private {!Array<function(!../api/client-event-manager-api.ClientEvent):!FilterResult>} */
                                   ^

third_party/subscriptions-project/swg.js:14104: WARNING - Failed to load module "../model/page-config"
   * @param {!../model/page-config.PageConfig} pageConfig
              ^

third_party/subscriptions-project/swg.js:14109: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.Config=} opt_config
              ^

third_party/subscriptions-project/swg.js:14122: WARNING - Failed to load module "../api/subscriptions"
    /** @private @const {!../api/subscriptions.Config} */
                          ^

third_party/subscriptions-project/swg.js:14134: WARNING - Failed to load module "../model/page-config"
    /** @private @const {!../model/page-config.PageConfig} */
                          ^

third_party/subscriptions-project/swg.js:14157: WARNING - Failed to load module "../components/activities"
    /** @private @const {!../components/activities.ActivityPorts} */
                          ^

third_party/subscriptions-project/swg.js:14268: WARNING - Failed to load module "../api/subscriptions"
   * @param {!../api/subscriptions.Config} config
              ^

@rsimha
Copy link
Contributor Author

rsimha commented Jul 9, 2019

@cvializ @alanorozco Tested this by injecting some genuine errors to make sure they continue to be reported. This is ready for review.

alanorozco
alanorozco approved these changes Jul 10, 2019
View reviewed changes
build-system/amp.extern.js Show resolved Hide resolved
@rsimha rsimha merged commit de8fdf4 into ampproject:master Jul 10, 2019
@rsimha rsimha deleted the 2019-07-09-CheckTypesWarnings branch July 10, 2019 01:04
@rsimha rsimha mentioned this pull request Jul 11, 2019
Merged
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
@rsimha
🏗 Silence / fix known warnings that appear when gulp check-types de…
76842e1 
…tects an error (ampproject#23242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

@cvializ cvializ Awaiting requested review from cvializ

Assignees

@rsimha rsimha

Labels
cla: yes WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsimha @alanorozco @googlebot