amp-script: Allow removal of attributes #23245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @jridgewell |
|
Friendly ping. |
jridgewell
approved these changes
Jul 17, 2019
src/purifier.js
Outdated
| @@ -390,17 +390,22 @@ export function validateAttributeChange(purifier, node, attr, value) { | |||
| if (whitelist) { | |||
| const {attribute, values} = whitelist; | |||
| if (attribute === attr) { | |||
| if (value == null || !values.includes(value)) { | |||
| if (value === null || !values.includes(value)) { | |||
There was a problem hiding this comment.
Do we know the value can't be undefined?
There was a problem hiding this comment.
Yea, the TS interface uses string | null. Maybe it's better to be defensive than readable here though.
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
* Allow removal of attributes. * Flipped a condition. * == instead of ===.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Allow removal of attributes. * Flipped a condition. * == instead of ===.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #23156.
DOMPurify.isValidAttributeexpects non-null values.[sandbox=allow-forms].WHITELISTED_ATTRSinvalidateAttributeChange()since I didn't realize those are already covered by the DOMPurify config.