Fix 3 viewports down bug #23288
Merged
Fix 3 viewports down bug #23288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparhami
approved these changes
Jul 11, 2019
|
Alas, unit tests for |
jridgewell
approved these changes
Jul 12, 2019
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
* Fix 3 viewports down bug * Remove experiment toggles from tests since experiment has been launched
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Fix 3 viewports down bug * Remove experiment toggles from tests since experiment has been launched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The measurement from
positionRect.bottomis actually (a call togetClientBoundingRect) measuring distance from viewport top already, not distance from the beginning of the page. There is no need to subtract the scrollTop distance in this case.