amp-bind: Don't get stuck on sibling-less amp-list #23333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
commented
Jul 15, 2019
|
|
||
| // But cousins and the amp-list itself shouldn't be skipped. | ||
| expect(list.className).to.equal('x'); | ||
| expect(cousin.textContent).to.equal('6'); |
There was a problem hiding this comment.
Verified this line fails without the fix.
jridgewell
requested changes
Jul 15, 2019
extensions/amp-bind/0.1/bind-impl.js
Outdated
| skipSubtree_(walker) { | ||
| let n = walker.currentNode; | ||
| while (n) { | ||
| if (n.nextSibling) { |
There was a problem hiding this comment.
Please use walker.parentNode() and walker.nextSibling() only. As is, this will traverse outside of the walker's root and scan unrelated DOM trees.
jridgewell
approved these changes
Jul 15, 2019
jridgewell
pushed a commit
that referenced
this pull request
Jul 15, 2019
* Don't get stuck on sibling-less amp-list. * Use nextSibling/parentNode. * Yikes infinite loop.
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
* Don't get stuck on sibling-less amp-list. * Use nextSibling/parentNode. * Yikes infinite loop.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Don't get stuck on sibling-less amp-list. * Use nextSibling/parentNode. * Yikes infinite loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23281.
/to @jridgewell