馃悰 Catch invalid json responses in amp-addthis #23431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears (from our error logs) that the JSON requests occasionally return invalid JSON.
zhouyx
approved these changes
Jul 19, 2019
| }); | ||
| } | ||
| }, | ||
| () => {} |
There was a problem hiding this comment.
Do we want to send a user error?
There was a problem hiding this comment.
It's a server error, I'm not sure it'd be useful.
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
It appears (from our error logs) that the JSON requests occasionally return invalid JSON.
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
It appears (from our error logs) that the JSON requests occasionally return invalid JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears (from our error logs) that the JSON requests occasionally return invalid JSON. Maybe something to do with ad blocking?
Fixes #19253.
/cc @taojing10 @dmvjs @pjcunnin @matthinegardner