馃悰Remove string.trimStart() from expander #23439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Jul 20, 2019
|
I'm wondering why it was not failing any integration tests. @calebcordry could you take a look? |
|
@lannka not sure about edge, but looks like |
|
Could you add an integration test that will cover this code in |
|
https://kangax.github.io/compat-table/es2016plus/#test-string_trimming Edge doesn't have it, FF got it in 60, and Safari got it in 12. |
|
Introduced test in #23466 |
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
* use new trimStart * oops
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* use new trimStart * oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And introduce new trimStart helper in its place.
Closes #23432